Skip to content

feat: add UI Regex Validation #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 4, 2025
Merged

feat: add UI Regex Validation #774

merged 15 commits into from
Sep 4, 2025

Conversation

arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented Aug 18, 2025 •
edited
Loading

Description

https://github.ibm.com/GoldenEye/issues/issues/15220

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

Testing ss from UI:
Pasted Graphic 26
Prefix must begin with a lowercase letter and may contain only lowercase letters, digits,
Pasted Graphic 29
Pasted Graphic 28
existing_kms_instance_crn (optional) ®
existing_cluster_kms_key_crn (optional) ®
existing_cluster_kms_key_crn (optional) ®
existing_boot_volume_kms_key_crn (optional) ©
existing_boot_volume_kms_key_crn (optional) ®

@arya-girish-k arya-girish-k marked this pull request as ready for review August 20, 2025 08:39
@arya-girish-k
Copy link
Contributor Author

/run pipeline

Aashiq-J
Aashiq-J reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other inputs as well which can have the regex validation
audit_webhook_listener_image_tag_digest , existing_secrets_manager_instance_crn , secrets_manager_secret_group_id

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented Aug 21, 2025 •
edited
Loading

  • Regarding audit_webhook_listener_image_tag_digest as per the discussion adding validation here is not recommended.The user may wish to use their won image and they may wish to use an image tag instead of digest, yet the regex is only allowing digest.

  • existing_secrets_manager_instance_crn ,secrets_manager_secret_group_id Terraform validation are not present ,Do I need to add the validation?

CC: @Aashiq-J

@arya-girish-k
Copy link
Contributor Author

Added validation for the following variables:

  1. existing_secrets_manager_instance_crn
The value provided for 'existing_secrets_manager_instance_crn' is not valid Pasted Graphic 7
  1. secrets_manager_secret_group_id
secrets_manager_secret_group_id © secrets_manager_secret_group_id ©
  1. existing_vpc_crn
The value provided for 'existing_ypc_crn' is not valid
  1. existing_cos_instance_crn
The value provided for 'existing_cos_instance_crn' is not valid Pasted Graphic 3

@iamar7
Copy link
Member

iamar7 commented Sep 3, 2025

  1. Prefix validation -
Screenshot 2025-09-03 at 3 32 49 PM
  1. existing_vpc_crn validation -
Screenshot 2025-09-03 at 3 39 15 PM
  1. existing_cos_instance_crn validation -
Screenshot 2025-09-03 at 3 39 52 PM
  1. existing_kms_instance_crn & existing_cluster_kms_key_crn validation
Screenshot 2025-09-03 at 3 41 40 PM
  1. existing_boot_volume_kms_key_crn validation
Screenshot 2025-09-03 at 3 42 00 PM
  1. existing_secrets_manager_instance_crn & secrets_manager_secret_group_id validation
Screenshot 2025-09-03 at 3 42 24 PM

@iamar7
Copy link
Member

iamar7 commented Sep 3, 2025

/run pipeline

@iamar7
Copy link
Member

iamar7 commented Sep 3, 2025

/run pipeline

ocofaigh
ocofaigh reviewed Sep 3, 2025
View reviewed changes
ibm_catalog.json Outdated
{
"type": "regex",
"description": "The value provided for 'existing_vpc_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}is:(.*:){2}:vpc:[0-9a-z]{4}-[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike prefix, this can never be __NULL__ - remove from regex

ocofaigh
ocofaigh reviewed Sep 3, 2025
View reviewed changes
ibm_catalog.json Outdated
{
"type": "regex",
"description": "The value provided for 'existing_cos_instance_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}cloud-object-storage:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike prefix, this can never be __NULL__ - remove from regex

@iamar7
Copy link
Member

iamar7 commented Sep 4, 2025

/run pipeline

@iamar7
Copy link
Member

iamar7 commented Sep 4, 2025

Screenshot 2025-09-04 at 3 01 00 PM

@ocofaigh ocofaigh merged commit 472f216 into main Sep 4, 2025
2 checks passed
@ocofaigh ocofaigh deleted the regexvalidation branch September 4, 2025 12:20
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aashiq-J Aashiq-J Aashiq-J left review comments

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arya-girish-k @iamar7 @terraform-ibm-modules-ops @ocofaigh @Aashiq-J